internal: (studio) skip cancelling studio on watched:file:changed #31804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the runner’s event handling to avoid cancelling studio when a file change should only trigger a rerun, and adds an end-to-end test for the cloud studio scenario.
- Skip calling
studioStore.cancel()onwatched:file:changedwhen studio (local or cloud) is active - Remove the generic rerun binding array and explicitly bind only
runner:restartand the customwatched:file:changedhandler - Add a Cypress test to verify cloud studio remains open after spec file changes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/app/src/runner/event-manager.ts | Conditional studioStore.cancel() and explicit rerun event binding |
| packages/app/cypress/e2e/studio/studio-cloud.cy.ts | New test for cloud studio behavior on spec file changes |
Comments suppressed due to low confidence (2)
packages/app/cypress/e2e/studio/studio-cloud.cy.ts:209
- [nitpick] The test description says 'exits studio mode' but the assertion checks that the studio panel remains visible. Consider renaming it to 'does not exit studio mode...' or similar to match the behavior.
it('exits studio mode if the spec is changed on the file system', () => {
packages/app/src/runner/event-manager.ts:161
- Add a test case covering the scenario when
LOCAL_STUDIO_PATHis set (local studio) to ensure thatstudioStore.cancel()is correctly skipped for local studio as well.
if (!Cypress.env('LOCAL_STUDIO_PATH') && !Cypress.env('ENABLE_CLOUD_STUDIO')) {
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
mschile/studio/skip_studio_cancel_on_file_changed
|
| Run status |
|
| Run duration | 18m 49s |
| Commit |
|
| Committer | Matthew Schile |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
8
|
Pending
|
1232
|
Skipped
|
0
|
Passing
|
32182
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.11%
|
|
|---|---|
|
Untested elements
|
189
|
|
Tested elements
|
166
|
Accessibility
92.74%
|
|
|---|---|
|
Failed rules
|
3 critical
9 serious
2 moderate
2 minor
|
|
Failed elements
|
698
|
ryanthemanuel
approved these changes
May 30, 2025
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
studioStore.cancel()when the cloud studio is requestedrerunwas getting called twice due towatched:filed:changedbeing listened to twice. Depending on timing, this would lead to weird behavior where logs were duplicated on the reporter (it appeared there were two event managers running)Steps to test
How has the user experience changed?
studio_save.mov
PR Tasks
cypress-documentation?type definitions?